search

tableau / rest-api-samples

Samples for the Tableau REST API
MIT License
388 stars 272 forks source link

Updating REST API samples and readme files #27

Closed aaroncarey closed 6 years ago

aaroncarey commented 6 years ago
d45 commented 6 years ago

Should we be doing a merge with the development branch before opening the PR for master? Looks like they are out of sync. Not sure if that's what we've been doing for this repo. Other repos we typically checki in to the development branch first.

jdomingu commented 6 years ago

@d45 I rebased development from master, so they should be in sync now. Agreed that we have typically pushed to development and then merged to master. This is such a small repo though that maybe we should just get rid of the dev branch and use small feature branches like @aaroncarey has been doing. Let's discuss later (and also talk about deleting the already merged patch branches).

@aaroncarey this seems fine for today's change. 🚀 When you merge, can you use the squash and merge option? Thanks!

d45 commented 6 years ago

Sounds good to me. It is a small repo, so simplifying things makes sense. We should definite check with Russ and Lee about the development branch before nuking it.
@aaroncarey @jdomingu - The PR looks good. Jared, do you want to do the merge?

aaroncarey commented 6 years ago

Thanks to both of you for the review! I'll go ahead and "squash + merge" later this evening when other 2018.1 updates start. And I'll check with Ben / Russell / Lee about the development branch.

I have permissions to merge this PR when we are ready to go.