search

tableau / server-client-python

A Python library for the Tableau Server REST API
https://tableau.github.io/server-client-python/
MIT License
649 stars 418 forks source link

[TYPE 3] [Allow to override constants] #1186

Open ludwigrubio opened 1 year ago

ludwigrubio commented 1 year ago

Summary

Create a configuration file to centralize all constant in a single place, allowing users to override values as needed (Monkey patching)

Description

There is a constant _FILESIZE_LIMIT_ in the datasources_endpoint.py file that is hardcoded to chunk files after 64 MB.

Security policies implemented in a firewall on top of an application could have constrains about the max size of body request or max file upload that could differ in case to case and requires file to be chunked in smaller pieces.

jacalata commented 1 year ago

Sounds very reasonable, shouldn't be too hard.

Salatich commented 2 weeks ago

Thumbs up, it would be nice to have a possibility to override CHUNK_SIZE_MB as well.