search

tableau / server-client-python

A Python library for the Tableau Server REST API
https://tableau.github.io/server-client-python/
MIT License
656 stars 420 forks source link

Wrong type annotation in workbook.refresh #1318

Closed pes-magic closed 8 months ago

pes-magic commented 10 months ago

Describe the bug workbooks.refresh is implemented to receive workbook_id as a string type argument, but it can actually receive WorkbookItem as well. The documentation also states that it receives workbook_item.

Implementation: https://github.com/tableau/server-client-python/blob/master/tableauserverclient/server/endpoint/workbooks_endpoint.py#L91 Documentation: https://tableau.github.io/server-client-python/docs/api-ref#workbooksrefresh

Versions

To Reproduce Nothing to do

Results Static code analysis displays false warnings

jorwoods commented 8 months ago

@pes-magic Can you mark this as closed by #1319?

pes-magic commented 8 months ago

Sure, thank you for reminding me