search

tableau / server-client-python

A Python library for the Tableau Server REST API
https://tableau.github.io/server-client-python/
MIT License
656 stars 420 forks source link

Fixed type annotation for workbook.refresh #1319

Closed pes-magic closed 10 months ago

pes-magic commented 10 months ago

workbook.refresh is implemented to accept both WorkbookItem and str as arguments, but the type annotation describes it as receiving str, which can cause false warnings in static analysis.

Since the documentation states that it receives workbook_item, the name of the argument is also changed from workbook_id to workbook_item.

Issue: https://github.com/tableau/server-client-python/issues/1318

salesforce-cla[bot] commented 10 months ago

Thanks for the contribution! Before we can merge this, we need @pes-magic to sign the Salesforce Inc. Contributor License Agreement.

pes-magic commented 10 months ago

I've signed the CLA