search

tableau / server-client-python

A Python library for the Tableau Server REST API
https://tableau.github.io/server-client-python/
MIT License
655 stars 420 forks source link

CGI Removal #1346

Closed markm-io closed 7 months ago

markm-io commented 7 months ago

Removed cgi due to deprecation and updated to use email.message.Message instead.

salesforce-cla[bot] commented 7 months ago

Thanks for the contribution! Before we can merge this, we need @markm-io to sign the Salesforce Inc. Contributor License Agreement.

bcantoni commented 7 months ago

@markm-io thanks for putting this together. There are 2 other places the CGI module is used. Would you mind updating flows_endpoint.py and workbooks_endpoint.py here as well?

Also, you'll need to fix those black and mypy errors before this PR will go green. You can see the steps explained more in the dev guide.

markm-io commented 7 months ago

@markm-io thanks for putting this together. There are 2 other places the CGI module is used. Would you mind updating flows_endpoint.py and workbooks_endpoint.py here as well?

Also, you'll need to fix those black and mypy errors before this PR will go green. You can see the steps explained more in the dev guide.

All files have been updates and both black and mypy commands have been run with corrections made.