search

tableau / server-client-python

A Python library for the Tableau Server REST API
https://tableau.github.io/server-client-python/
MIT License
656 stars 420 forks source link

feat: tag everything #1422

Closed jorwoods closed 3 weeks ago

jorwoods commented 1 month ago

Closes #1421

jorwoods commented 1 month ago

Since workbooks, views, and data sources all follow the same pattern here, theoretically we could solve this with a Mixin class and add the functionality to all three with reduced duplication.

jorwoods commented 1 month ago

Virtual connections also follow this pattern and could have the functionality added via a mixin class if that's the route we want to go.

jacalata commented 1 month ago

yes, I think that's a great idea. I'd love to get all the shared functionality actually extracted from individual objects in this code.

jorwoods commented 1 month ago

After this gets merged, I can rebase #1429 and add tagging support for virtual connections as well.