tableau / tableau-log-viewer

Tableau Log Viewer is a cross-platform tool for quickly glancing over Tableau log files
MIT License
172 stars 51 forks source link

Create a button to add new hightlight filters #100

Closed luiseeo closed 6 years ago

luiseeo commented 6 years ago

The Highlight filter dialog now has a button to add new filters. No need to use a keyboard shortcut unless you want to.

This is how it looks in a light theme: image

This is how it looks in a dark theme: image

vogelsgesang commented 6 years ago

Good idea - talking to team members, quite a few of them did not know you can create multiple filters

Personally, I would prefer Chrome's/Firefox' style for this button, i.e. directly next to the right-most tab, but left-aligned instead of aligned to the right:

screen shot 2018-09-07 at 03 17 35
luiseeo commented 6 years ago

@vogelsgesang I agree with your suggestion. However, I tried to get the look of firefox/chrome but I failed. Qt doesn't natively support the Add Tab control. I tried different approaches but, at the end, they were hacky and didn't quite worked as I would hope (one of the approaches was adding a tab at the end that should only be clickable but don't have contents; I got a lot of unexpected behavior like if you delete the 2nd to last tab Qt would show you the next tab... which in this case is empty)

Other than creating/deriving a new TabWidget class, there is no easy way to get the firefox/chrome interface.

The TabWidget supports natively is adding other widgets on their corners. This was easy to code and didn't bring any unexpected behavior.

vogelsgesang commented 6 years ago

I just realized: We reached the pull request ID 💯 😄