tableau / tableau-log-viewer

Tableau Log Viewer is a cross-platform tool for quickly glancing over Tableau log files
MIT License
172 stars 51 forks source link

Add options to show/hide ART data and erro code in Value #109

Closed luiseeo closed 5 years ago

luiseeo commented 5 years ago

Fix for issue #105

Problem: ART data was added to the value under the "~art" attribute. Many persons complained that ART data is not easy to read and most of the time it just gets in the way to read something else. Since TLV objective is to make logs more readable, having a mechanism to declutter the view is welcome. (something similar happen with "Error Code" column and "~errorcode" artificial attribute)

The Options dialog now has 2 new options: image

These options are persisted and, by default, they have a "false" value (=> existing TLV users should see the "~art" text disappear without changing any settings)

By removing the ART data and Error code information from the value another problem emerged: it wouldn't be possible to use them in searches. This is actually caused by the fact that we haven't added the ART and Error Code columns to our find and highlight dialogs. This issue is also fixed:

image

In that example we create a highlight filter for a very specific error code. I tested that finding and highlighting works independently of the values of the new options.