search

tableau / tableau-log-viewer

Tableau Log Viewer is a cross-platform tool for quickly glancing over Tableau log files
MIT License
172 stars 51 forks source link

Don’t try to format plain strings as JSON objects #96

Closed TheAlmightyBob closed 6 years ago

TheAlmightyBob commented 6 years ago

Bypass the Flat/Raw/YAML formatters if the QJsonValue is just a string.

vogelsgesang commented 6 years ago

It would be nice to have a slightly more descriptive git log message. It's good that we state what we are doing, but it would be even

vogelsgesang commented 6 years ago

Sorry, hit the wrong button accidentally :/

It would be nice to have a slightly more descriptive git log message. It's good that we state what we are doing, but it would be even better to also have a sentence or two on why we are doing it. Something like "Before this change, top-level strings were rendered incorrectly, since, e.g., the flat format always prepended a single : in front of the string."

TheAlmightyBob commented 6 years ago

Squashed commits and updated description.