tablecheck / tablekit

Next generation UI component library
https://tablekit.tablecheck.com/
MIT License
9 stars 2 forks source link

fix: spinner should resize correctly #207

Closed SimeonC closed 1 year ago

SimeonC commented 1 year ago

See video for the issue and why this fixes it when setting --spinner-size: 48px;

https://github.com/tablecheck/tablekit/assets/1085899/18ba24aa-e8eb-4555-a179-042702d23d13

πŸ“¦ Published PR as canary version: Canary Versions
:sparkles: Test out this PR locally via: ```bash npm install @tablecheck/tablekit-core@2.0.1-canary.207.6256628576.0 npm install @tablecheck/tablekit-css@2.0.1-canary.207.6256628576.0 npm install @tablecheck/tablekit-react-css@2.0.1-canary.207.6256628576.0 npm install @tablecheck/tablekit-react-datepicker@2.0.1-canary.207.6256628576.0 npm install @tablecheck/tablekit-react-fit-content-textarea@2.0.1-canary.207.6256628576.0 npm install @tablecheck/tablekit-react-select@2.0.1-canary.207.6256628576.0 npm install @tablecheck/tablekit-react@2.0.1-canary.207.6256628576.0 # or yarn add @tablecheck/tablekit-core@2.0.1-canary.207.6256628576.0 yarn add @tablecheck/tablekit-css@2.0.1-canary.207.6256628576.0 yarn add @tablecheck/tablekit-react-css@2.0.1-canary.207.6256628576.0 yarn add @tablecheck/tablekit-react-datepicker@2.0.1-canary.207.6256628576.0 yarn add @tablecheck/tablekit-react-fit-content-textarea@2.0.1-canary.207.6256628576.0 yarn add @tablecheck/tablekit-react-select@2.0.1-canary.207.6256628576.0 yarn add @tablecheck/tablekit-react@2.0.1-canary.207.6256628576.0 ```
netlify[bot] commented 1 year ago

Deploy Preview for tablekit ready!

Name Link
Latest commit a8f022e39b3546d86ffee8024523da6f5cdbcc9f
Latest deploy log https://app.netlify.com/sites/tablekit/deploys/650bb17358369d0009b4e743
Deploy Preview https://deploy-preview-207--tablekit.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 1 year ago

Unit Test Results

0 tests  Β±0   0 :heavy_check_mark: Β±0   0s :stopwatch: Β±0s 0 suites Β±0   0 :zzz: Β±0  1 files   Β±0   0 :x: Β±0 

Results for commit a8f022e3. ± Comparison against base commit 59b6fb39.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 year ago

:rocket: PR was released in @tablecheck/tablekit-core@3.0.0-next.22, @tablecheck/tablekit-css@3.0.0-next.23, @tablecheck/tablekit-react-css@3.0.0-next.23, @tablecheck/tablekit-react-datepicker@3.0.0-next.22, @tablecheck/tablekit-react-fit-content-textarea@3.0.0-next.22, @tablecheck/tablekit-react-select@3.0.0-next.24, @tablecheck/tablekit-react@3.0.0-next.22 :rocket: