tablecheck / tablekit

Next generation UI component library
https://tablekit.tablecheck.com/
MIT License
9 stars 2 forks source link

fix(tablekit-react-select): allow maxMenuHeight to work #209

Closed k-baldauf closed 1 year ago

k-baldauf commented 1 year ago

Due to how our CSS works when using react-select, we have a styling that gets applied with priority over the max-height set by maxMenuHeight. This PR sticks !important on that CSS so it wins out.

A use case with maxMenuHeight prop set to 600:

Before:

CSS rules showing 300px overriding 600px

After:

CSS rules showing the 600px having priority over 300px
πŸ“¦ Published PR as canary version: Canary Versions
:sparkles: Test out this PR locally via: ```bash npm install @tablecheck/tablekit-core@2.0.1-canary.209.6479917599.0 npm install @tablecheck/tablekit-css@2.0.1-canary.209.6479917599.0 npm install @tablecheck/tablekit-react-css@2.0.1-canary.209.6479917599.0 npm install @tablecheck/tablekit-react-datepicker@2.0.1-canary.209.6479917599.0 npm install @tablecheck/tablekit-react-fit-content-textarea@2.0.1-canary.209.6479917599.0 npm install @tablecheck/tablekit-react-select@2.0.1-canary.209.6479917599.0 npm install @tablecheck/tablekit-react@2.0.1-canary.209.6479917599.0 # or yarn add @tablecheck/tablekit-core@2.0.1-canary.209.6479917599.0 yarn add @tablecheck/tablekit-css@2.0.1-canary.209.6479917599.0 yarn add @tablecheck/tablekit-react-css@2.0.1-canary.209.6479917599.0 yarn add @tablecheck/tablekit-react-datepicker@2.0.1-canary.209.6479917599.0 yarn add @tablecheck/tablekit-react-fit-content-textarea@2.0.1-canary.209.6479917599.0 yarn add @tablecheck/tablekit-react-select@2.0.1-canary.209.6479917599.0 yarn add @tablecheck/tablekit-react@2.0.1-canary.209.6479917599.0 ```
netlify[bot] commented 1 year ago

Deploy Preview for tablekit ready!

Name Link
Latest commit 406ea1dbeef919a3148f146bbd0ca7ed7898abe9
Latest deploy log https://app.netlify.com/sites/tablekit/deploys/65265be6209a0300084b2d97
Deploy Preview https://deploy-preview-209--tablekit.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 1 year ago

Unit Test Results

0 tests  Β±0   0 :heavy_check_mark: Β±0   0s :stopwatch: Β±0s 0 suites Β±0   0 :zzz: Β±0  1 files   Β±0   0 :x: Β±0 

Results for commit 406ea1db. ± Comparison against base commit defb8856.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 1 year ago

:rocket: PR was released in @tablecheck/tablekit-react-select@3.0.0-next.25 :rocket: