search

tablecheck / tablekit

Next generation UI component library
https://tablekit.tablecheck.com/
MIT License
9 stars 2 forks source link

fix: date picker buttons need type=“button” #213

Closed SimeonC closed 12 months ago

SimeonC commented 1 year ago

To prevent accidental submission of forms, found this in one of our tests where clicking a date would submit the parent form.

📦 Published PR as canary version: Canary Versions
:sparkles: Test out this PR locally via: ```bash npm install @tablecheck/tablekit-core@2.0.1-canary.213.6976450883.0 npm install @tablecheck/tablekit-css@2.0.1-canary.213.6976450883.0 npm install @tablecheck/tablekit-react-css@2.0.1-canary.213.6976450883.0 npm install @tablecheck/tablekit-react-datepicker@2.0.1-canary.213.6976450883.0 npm install @tablecheck/tablekit-react-fit-content-textarea@2.0.1-canary.213.6976450883.0 npm install @tablecheck/tablekit-react-select@2.0.1-canary.213.6976450883.0 npm install @tablecheck/tablekit-react@2.0.1-canary.213.6976450883.0 # or yarn add @tablecheck/tablekit-core@2.0.1-canary.213.6976450883.0 yarn add @tablecheck/tablekit-css@2.0.1-canary.213.6976450883.0 yarn add @tablecheck/tablekit-react-css@2.0.1-canary.213.6976450883.0 yarn add @tablecheck/tablekit-react-datepicker@2.0.1-canary.213.6976450883.0 yarn add @tablecheck/tablekit-react-fit-content-textarea@2.0.1-canary.213.6976450883.0 yarn add @tablecheck/tablekit-react-select@2.0.1-canary.213.6976450883.0 yarn add @tablecheck/tablekit-react@2.0.1-canary.213.6976450883.0 ```
netlify[bot] commented 1 year ago

Deploy Preview for tablekit ready!

Name Link
Latest commit 4bc654dfbab5989dd1fdd214254f45097f08ca46
Latest deploy log https://app.netlify.com/sites/tablekit/deploys/656014fe158d700008ec7860
Deploy Preview https://deploy-preview-213--tablekit.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 1 year ago

Unit Test Results

0 tests  ±0   0 :heavy_check_mark: ±0   0s :stopwatch: ±0s 0 suites ±0   0 :zzz: ±0  1 files   ±0   0 :x: ±0 

Results for commit 4bc654df. ± Comparison against base commit 7654b4f3.

github-actions[bot] commented 11 months ago

:rocket: PR was released in @tablecheck/tablekit-core@3.0.0-next.26, @tablecheck/tablekit-css@3.0.0-next.27, @tablecheck/tablekit-react-css@3.0.0-next.27, @tablecheck/tablekit-react-datepicker@3.0.0-next.27, @tablecheck/tablekit-react-fit-content-textarea@3.0.0-next.26, @tablecheck/tablekit-react-select@3.0.0-next.29, @tablecheck/tablekit-react@3.0.0-next.26 :rocket: