tablecheck / tablekit

Next generation UI component library
https://tablekit.tablecheck.com/
MIT License
9 stars 2 forks source link

fix(input-alert): handle case when no icon #217

Closed SimeonC closed 8 months ago

SimeonC commented 8 months ago

The "Bare" and "Disabled" input-alert types have no icons associated, in this case we should handle a "Single Element"

https://github.com/tablecheck/tablekit/blob/a13a4a5ca1a5e10ae0a5e6c6d5d1a21004f7193c/system/react/src/structuredComponents/InputAlert.tsx#L14-L23

Current NEXT branch

CleanShot 2024-03-11 at 11 54 35

This Fix

CleanShot 2024-03-11 at 11 56 14

πŸ“¦ Published PR as canary version: Canary Versions
:sparkles: Test out this PR locally via: ```bash npm install @tablecheck/tablekit-core@2.0.1-canary.217.8258750336.0 npm install @tablecheck/tablekit-css@2.0.1-canary.217.8258750336.0 npm install @tablecheck/tablekit-react-css@2.0.1-canary.217.8258750336.0 npm install @tablecheck/tablekit-react-datepicker@2.0.1-canary.217.8258750336.0 npm install @tablecheck/tablekit-react-fit-content-textarea@2.0.1-canary.217.8258750336.0 npm install @tablecheck/tablekit-react-select@2.0.1-canary.217.8258750336.0 npm install @tablecheck/tablekit-react@2.0.1-canary.217.8258750336.0 # or yarn add @tablecheck/tablekit-core@2.0.1-canary.217.8258750336.0 yarn add @tablecheck/tablekit-css@2.0.1-canary.217.8258750336.0 yarn add @tablecheck/tablekit-react-css@2.0.1-canary.217.8258750336.0 yarn add @tablecheck/tablekit-react-datepicker@2.0.1-canary.217.8258750336.0 yarn add @tablecheck/tablekit-react-fit-content-textarea@2.0.1-canary.217.8258750336.0 yarn add @tablecheck/tablekit-react-select@2.0.1-canary.217.8258750336.0 yarn add @tablecheck/tablekit-react@2.0.1-canary.217.8258750336.0 ```
netlify[bot] commented 8 months ago

Deploy Preview for tablekit ready!

Name Link
Latest commit 8a4b6ed76237253d934562529dc4a6407a89c153
Latest deploy log https://app.netlify.com/sites/tablekit/deploys/65f11426c6d0e100083d9d5c
Deploy Preview https://deploy-preview-217--tablekit.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 8 months ago

Unit Test Results

0 tests  Β±0   0 :heavy_check_mark: Β±0   0s :stopwatch: Β±0s 0 suites Β±0   0 :zzz: Β±0  1 files   Β±0   0 :x: Β±0 

Results for commit 8a4b6ed7. ± Comparison against base commit a13a4a5c.

:recycle: This comment has been updated with latest results.

github-actions[bot] commented 8 months ago

:rocket: PR was released in @tablecheck/tablekit-core@3.0.0-next.28, @tablecheck/tablekit-css@3.0.0-next.29, @tablecheck/tablekit-react-css@3.0.0-next.29, @tablecheck/tablekit-react-datepicker@3.0.0-next.29, @tablecheck/tablekit-react-fit-content-textarea@3.0.0-next.28, @tablecheck/tablekit-react-select@3.0.0-next.31, @tablecheck/tablekit-react@3.0.0-next.28 :rocket: