search

tablecheck / tablekit

Next generation UI component library
https://tablekit.tablecheck.com/
MIT License
9 stars 2 forks source link

fix: disabled styles for Checkbox and Radio labels #222

Closed SashaShostyr closed 6 months ago

SashaShostyr commented 7 months ago

Issue example:

image
📦 Published PR as canary version: Canary Versions
:sparkles: Test out this PR locally via: ```bash npm install @tablecheck/tablekit-core@2.0.1-canary.222.9078713800.0 npm install @tablecheck/tablekit-css@2.0.1-canary.222.9078713800.0 npm install @tablecheck/tablekit-react-css@2.0.1-canary.222.9078713800.0 npm install @tablecheck/tablekit-react-datepicker@2.0.1-canary.222.9078713800.0 npm install @tablecheck/tablekit-react-fit-content-textarea@2.0.1-canary.222.9078713800.0 npm install @tablecheck/tablekit-react-select@2.0.1-canary.222.9078713800.0 npm install @tablecheck/tablekit-react@2.0.1-canary.222.9078713800.0 # or yarn add @tablecheck/tablekit-core@2.0.1-canary.222.9078713800.0 yarn add @tablecheck/tablekit-css@2.0.1-canary.222.9078713800.0 yarn add @tablecheck/tablekit-react-css@2.0.1-canary.222.9078713800.0 yarn add @tablecheck/tablekit-react-datepicker@2.0.1-canary.222.9078713800.0 yarn add @tablecheck/tablekit-react-fit-content-textarea@2.0.1-canary.222.9078713800.0 yarn add @tablecheck/tablekit-react-select@2.0.1-canary.222.9078713800.0 yarn add @tablecheck/tablekit-react@2.0.1-canary.222.9078713800.0 ```
netlify[bot] commented 7 months ago

Deploy Preview for tablekit ready!

Name Link
Latest commit 5f5548383a31feb478e37de317212a6786d48fdd
Latest deploy log https://app.netlify.com/sites/tablekit/deploys/66434dc4715add0008e6eb50
Deploy Preview https://deploy-preview-222--tablekit.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 7 months ago

Unit Test Results

0 tests  ±0   0 :heavy_check_mark: ±0   0s :stopwatch: ±0s 0 suites ±0   0 :zzz: ±0  1 files   ±0   0 :x: ±0 

Results for commit 5f554838. ± Comparison against base commit e6cf4f89.

:recycle: This comment has been updated with latest results.

SashaShostyr commented 6 months ago

This kind of change allows for incorrect semantics so we don't want to do that. Disabled styles on an input should only be applied when the pseudo element or prop is there.

Removed

SimeonC commented 6 months ago

I'll close this as this is included in #223 with the tests and everything to check it's working.