search

tableflip / guvnor

A node process manager that isn't spanners all the way down
MIT License
430 stars 37 forks source link

Is there a no-daemon mode? #39

Closed goloroden closed 9 years ago

goloroden commented 9 years ago

E.g., inside of a Docker container, if I want to use guvnor as command, then the Docker container exits as soon as the application has been started, since guvnor itself exits.

pm2 has a --no-daemon parameter for this.

How do I do this with guvnor?

achingbrain commented 9 years ago

Right now it's not possible, sorry! It's a valid use case though, I'll make sure there's something in a release really soon.

goloroden commented 9 years ago

Thanks, that's very nice :-))

goloroden commented 9 years ago

Since we need this feature … is there anything we can do to help?

I don't know whether we are able to do it, but could you point out where things need to be done? Then we might create a PR (I can't promise anything, but we at least would like to have a look at it).

achingbrain commented 9 years ago

This is in 3.2.0 - there's a relevant section in the readme.

PRs are very gratefully received - please do pitch in if you spot any problems.

goloroden commented 9 years ago

Just that I get the point: It's fixed by 3.2.0, but you are still looking for a PR?

Is there anything else that needs to be done before this issue can be closed?

achingbrain commented 9 years ago

No, I meant that in general PRs are gratefully received ;)

I think this issue can be closed. Usually I'd let the opener close it when they feel that the issue has been resolved.