Open alanshaw opened 9 years ago
@alanshaw I think @jadeqwang sees it as an effective way to measure the goodness of apps against each other. In the case of 100% it might be better not to have a bar at all or only show a thumbs up when it's 100% positive(with no thumbs down) and a thumbs down when it's 100% negative(with no thumbs up). Both thumbs should only display if there are positive and negative reviews. Even so... I can imagine if you have some 100% positive and 100% negative reviews on the app page then they wouldn't be perfectly aligned to the left(depending on if there's a thumbs up or down) which will look very ugly...
I'll think more about this and see if we can come up with something better.
Yeah, I think in the above case (100%), there should be no :-1: displayed, and probably not label "100%" either, but not sure how the alignment would work out. Curious what @neynah thinks of.
@jadeqwang I think in the case of reviews that are 100% negative or 100% positive, we'll keep the thumbs(up or down) on the left side. That will resolve the alignment issue. Another alternative would be to keep it as a thumbs-up on the left side(with no thumbs down on the right side), then the % on the bar will display how positive the reviews are. The thumbs down would only show if all reviews are negative (and would also display on the left side). If this is all too confusing I can mock it up. :)
We could also simply have "87% Positive" or "Mostly Positive" text instead of the progress bar & thumbs. This would clean up the UI too.
I think this is improved from before, but can still be a bit confusing:
When I click :+1: , it's true, the buttons shown are the 3 actions I can take, but somehow, it feels like I've set the state to :-1:, whereas it's merely that I have the option of clicking :-1: if I fat-fingered the :+1: .
I believe the answer to that is a toggle-style button for the [:+1:|:-1: ], where the :+1: doesn't disappear.
@jadeqwang I agree. I've suggested improvements on #189 but no response there yet.
@jadeqwang We've agreed on the revision of the toggle & buttons(let me know if there are any issues with these) but still waiting to hear back on the detailed breakdown of reviews.
Yeah, this should probably get merged with #189
Are the icons the wrong way round?
Is a progress bar the right UI element for this kind of thing?