search

tableflip / sandstorm-appstore

Appstore for Sandstorm.io
http://sandstorm-app-store-test.ga/
Apache License 2.0
6 stars 1 forks source link

App developer display name should not be Github username #218

Open kentonv opened 9 years ago

kentonv commented 9 years ago

When I log in as a Github user, the app store credits my apps as being from "kentonv" -- my Github user name. However, nothing in the UI indicates that this is a Github username, and since we offer multiple login mechanisms I don't think we want to use Github usernames for identity.

Normally, Meteor populates the user.profile.name field with the user's full name, which it fetches from Google or Github profile info. For some reason, the app store does not seem to have populated this field in my Meteor.user() entry. But in any case, this is the name we should use by default.

We should additionally allow the user to modify their display name, perhaps on the login/logout page.

richsilv commented 9 years ago

Okay, @kentonv, Github login now uses the user's full name rather than their Github username as their default App Store username.

A UI to change it is a small enhancement.

neynah commented 9 years ago

@kentonv Like this? Also, can a user change their username infinite times? sandstorm-app-store-login3

kentonv commented 9 years ago

@neynah Looks good to me.