search

tableflip / sandstorm-appstore

Appstore for Sandstorm.io
http://sandstorm-app-store-test.ga/
Apache License 2.0
6 stars 1 forks source link

Update formatting for app review on single app page #25

Closed jadeqwang closed 9 years ago

jadeqwang commented 9 years ago

I tried to leave a review, and the "submit review" button doesn't work. And it's the same for any app.

image

This is also weird because I swear, I tried this a few hours ago, and I was failing to leave a review in a different failure mode (where the button was purple instead of white).

Has a new version been deployed in the past couple hours?

jadeqwang commented 9 years ago

Ah ha. Apparently I can only submit a review if I first give it a star rating, which was not at all obvious to me, and that's what's different from a couple hours ago.

However, when I hit the "submit review" button, nothing happens. I don't see my review pop up in the reviews section. I see that I can still edit my review (which isn't necessarily the wrong behavior), but I can't tell that I've hit the "submit review" button at all...

image

richsilv commented 9 years ago

The reviews section is not reactive to avoid client-side redraws and lighten server load. If you navigate away and then back again, or reload, can you see the review you've left?

If so, it's a matter of two things:

  1. Adding the review to the client-side collection with a stub method and updating the carousel on posting, so that the user can see the review they've just posted, even if the box still isn't actually reactive (which I think is sensible from the perspective of server load).
  2. Make it more obvious that the review needs a star rating before submission with some validation formatting.

If, however, the user should be able to leave a review without a star rating, let me know and I'll change it so that they can.

jadeqwang commented 9 years ago

@richsilv , when I navigate back, I can see the review, so I think your two things is right.

I don't think I'm very opinionated on whether star ratings should be required for a review, but I think it'll be simpler to change it so they can leave a review without a star rating.

@neynah , I also kept trying to click on the 5 stars right under "Reviews" instead of the one on the right. Any suggestion as to how to make that less confusing? Off the top of my head, I'm thinking: maybe when they click the 'expand' triangle, the "average" star rating gets replaced by the interactive one. What do you think?

image

neynah commented 9 years ago

@richsilv I don't think stars should be required for a review.

@jadeqwang I think a simple solution here would to style them slightly differently, e.g. on the left we could have black and grey stars to indicate that its not something the user can control. The other alternative could be to display the stars underneath after the user clicks "write a review."

richsilv commented 9 years ago

Okay, makes sense. Presumably the stars line should not appear in a review without a rating attached (so it doesn't look like they've given it 0/5)? On 6 May 2015 1:06 am, "Néna Nguyễn" notifications@github.com wrote:

@richsilv https://github.com/richsilv I don't think stars should be required for a review.

@jadeqwang https://github.com/jadeqwang I think a simple solution here would to style them slightly differently, e.g. on the left we could have black and grey stars to indicate that its not something the user can control. The other alternative could be to display the stars underneath after the user clicks "write a review."

— Reply to this email directly or view it on GitHub https://github.com/tableflip/sandstorm-appstore/issues/25#issuecomment-99267134 .

jadeqwang commented 9 years ago

@richsilv +1. If they haven't rated, let's not render stars.

richsilv commented 9 years ago

Updated as requested.

@neynah - could you have a look at http://sandstorm-app-store-test.meteor.com/appMarket/app/PHcMs7Z4BRwuteRKB and let me know what you think?

jadeqwang commented 9 years ago

image

richsilv commented 9 years ago

All Meteor.com apps were down yesterday due to some MongoDB problem. We had that across the board.

It looks like it's resolved today, and I've deployed an updated version which includes the Edit App page.

On Wed, May 13, 2015 at 12:04 AM, Jade Q Wang notifications@github.com wrote:

[image: image] https://cloud.githubusercontent.com/assets/1584904/7600487/7f3acd92-f8c0-11e4-8566-d9a87fec4ebf.png

— Reply to this email directly or view it on GitHub https://github.com/tableflip/sandstorm-appstore/issues/25#issuecomment-101453996 .

neynah commented 9 years ago

@richsilv I think this is better. Would it be possible to have the stars on the right get highlighted (dark colour) upon hover and lock them in on click? The animation would make it more obvious that an input is needed.

Could we also thin out the arrows/angles a bit for the screens as well as reviews- they're rather plumpy.

Also a small styling adjustment to the "Write a review." Making the triangle a bit smaller and aligning it to the bottom. write-review