search

tablelandnetwork / evm-tableland

Tableland Smart Contracts - Simple solidity tooling to interact with Tableland from on-chain calls.
https://tableland.xyz
MIT License
39 stars 11 forks source link

[REVM-15] Upgrade to ethers v6 #337

Closed joewagner closed 1 year ago

joewagner commented 1 year ago

Now that Ethers v6 has been released we should start to work towards using it here so that the SDK can upgrade to v6. There will be some complexity in upgrading. This package has ethers as a dev dependency, and some of the other dev dependencies mark ethers as a peer dependency. Those peer dependencies all currently have ethers v5 tagged. Looking at the github repos for these packages makes it seem like they are all going to have versions that use v6 coming out soon. We should be ready for all those upgrades here.

related: https://github.com/NomicFoundation/hardhat/issues/3639 https://github.com/tablelandnetwork/tableland-js/issues/41

REVM-15

joewagner commented 1 year ago

@sanderpick Looks like you closed this last week. This work is blocking some other issues that are still open. Are we going to deprioritize upgrading ethers?

sanderpick commented 1 year ago

oop, the issue is over in Linear now. I had synced / unsynced this repo multiple times when testing the sync tool. so ended up just unsyncing issues. we could add the public tag on linear side if we wanted to make a new issue show up here.

joewagner commented 1 year ago

oop, the issue is over in Linear now. I had synced / unsynced this repo multiple times when testing the sync tool. so ended up just unsyncing issues. we could add the public tag on linear side if we wanted to make a new issue show up here.

That makes sense. I think it would be good to have this as public since this is blocked by a public PR in hardhat and it's nice for folks to be able to see all of that in github