search

tablelandnetwork / evm-tableland

Tableland Smart Contracts - Simple solidity tooling to interact with Tableland from on-chain calls.
https://tableland.xyz
MIT License
39 stars 11 forks source link

[EVM-15] Upgrade to ethers v6 #371

Closed sanderpick closed 9 months ago

sanderpick commented 1 year ago

Now that Ethers v6 has been released we should start to work towards using it here so that the SDK can upgrade to v6. There will be some complexity in upgrading. This package has ethers as a dev dependency, and some of the other dev dependencies mark ethers as a peer dependency. Those peer dependencies all currently have ethers v5 tagged. Looking at the github repos for these packages makes it seem like they are all going to have versions that use v6 coming out soon. We should be ready for all those upgrades here.

related: https://github.com/NomicFoundation/hardhat/issues/3639 https://github.com/tablelandnetwork/tableland-js/issues/41

From SyncLinear.com | EVM-15

sanderpick commented 1 year ago

cc @joewagner

awmuncy commented 1 year ago

Gonna have to bump this to next cycle. Nomic is close to done, it seems, but the issue is still open.

sanderpick commented 1 year ago

@awmuncy can you pull this into its own project? I think that would be easier to deal with… we can then close the giant tooling table stakes project.

awmuncy commented 1 year ago

Yep, tickets related to the Ethers v6 upgrade have been moved into their own project. And with that, the tooling table stakes project is complete.

joewagner commented 1 year ago

Just looked at this again. Hardhat has setup some beta support for v6, but open zeppelin has conflicting peer deps if we try to upgrade. Looks like OZ has a dependency bot that created a PR, but it will need someone to manually upgrade. https://github.com/OpenZeppelin/openzeppelin-upgrades/pull/736