tablelandnetwork / go-tableland

Go implementation of the Tableland database/validator - run your own node, handling on-chain events and serving read-queries

https://tableland.xyz/

MIT License

53 stars 10 forks source link

[got-111] change empty /query status to 200 #587

Closed avichalp closed 1 year ago

avichalp commented 1 year ago

Summary

This PR ensures that we don't return 404 from the Gateway API if the table is empty i.e. there are no rows in the table.

Context

[GOT-111] [JST-28]

Checklist

[ ] Are changes backward compatible with existing SDKs, or is there a plan to manage it correctly?
[x] Are changes covered by existing tests, or were new tests included?
[x] Are code changes optimized for future code readers, commenting on problematic areas to understand (if any)?
[x] Future-self question: Did you avoid unjustified/unnecessary complexity to achieve the goal?

linear[bot] commented 1 year ago

GOT-111 Change response code from 404 to 200 on "row not found" in gateway

context: [https://github.com/tablelandnetwork/docs/pull/53/files#r1051388080](https://github.com/tablelandnetwork/docs/pull/53/files#r1051388080) and [https://discord.com/channels/592843512312102924/1072296867037192232/1123368984356601926](https://discord.com/channels/592843512312102924/1072296867037192232/1123368984356601926)