tablelandnetwork / go-tableland

Go implementation of the Tableland database/validator - run your own node, handling on-chain events and serving read-queries

https://tableland.xyz/

MIT License

53 stars 10 forks source link

remove arb and eth goerli networks #608

Closed avichalp closed 10 months ago

avichalp commented 10 months ago

Summary

This PR removes support for arbitrum and ethereum goerli networks. See #607 for details

[x] Are changes backward compatible with existing SDKs, or is there a plan to manage it correctly?
[x] Are changes covered by existing tests, or were new tests included?
[x] Are code changes optimized for future code readers, commenting on problematic areas to understand (if any)?
[x] Future-self question: Did you avoid unjustified/unnecessary complexity to achieve the goal?

asutula commented 10 months ago

Will the validator still support read queries (and other types of gateway requests) for tables on these goerli networks?

avichalp commented 10 months ago

@asutula i don't think so. the tables will still be there in the validator's database but the gateway has this notion of "supported chains". it rejects any query to an unsupported chain

brunocalza commented 10 months ago

Will the validator still support read queries (and other types of gateway requests) for tables on these goerli networks?

The query will work, actually. The check of supported chains does not happen in the /query call. Can't remember if that was by design or an accident.

Either way, an additional comment: if we ever start the validator from scratch again, the data would be lost because the validator wouldn't pick the events of a not-supported chain (we'd still have them in the backups taken when the chain was supported). We don't have the concept of "network was supported between this interval, so pick those events up".

asutula commented 10 months ago

Thanks for the info @brunocalza.

if we ever start the validator from scratch again

This implies that if any new validator joins the nework, they won't have the data. Seems we should consider the data gone/unavailable then. I could be smart to delete the tables from the validator state (and Studio's state), but that may be another conversation.