search

tablelandnetwork / studio

Discover, design, deploy, and manage data driven web3 apps on Tableland.
https://studio.tableland.xyz
4 stars 1 forks source link

Table page v0.1 #202

Closed asutula closed 7 months ago

asutula commented 7 months ago

Just a most basic implementation that refactors the Deployment component to be general use and uses it in both the Deployment screen and Tableland table page.

railway-app[bot] commented 7 months ago

This PR is being deployed to Railway 🚅

web: ◻️ REMOVED

joewagner commented 7 months ago

This looks great! I'm exited to be able to use studio to look at tableland in a more general way. The only thing I can find is a nit that existed before this PR.

The Card component allows titles to overflow out of the card border.

Screen Shot 2024-02-29 at 9 32 49 AM

Here's a potential change, but open to leaving it how it is too. https://github.com/tablelandnetwork/studio/compare/asutula/table-page...joe/table-page?expand=1

asutula commented 7 months ago

Yea, that annoying bug. I'd prefer to tackle that separately. We shouldn't edit those shad cn components unless absolutely necessary. There is probably a way to achieve what we want by setting the class were we use the Card component. Let's figure it out later.

joewagner commented 7 months ago

Yea, that annoying bug. I'd prefer to tackle that separately. We shouldn't edit those shad cn components unless absolutely necessary. There is probably a way to achieve what we want by setting the class were we use the Card component. Let's figure it out later.

Sounds good, I can open a PR with ShadCN. I was assuming that since it's committed to our repo it was our component.