Closed asutula closed 6 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
studio | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Mar 30, 2024 2:22am |
This PR is being deployed to Railway 🚅
web: ◻️ REMOVED
@joewagner I'm having trouble understanding why/where the tests are failing. Let me know if you can tell.
@joewagner I'm having trouble understanding why/where the tests are failing. Let me know if you can tell.
Oh I see some needed updates that need to be made to the tests. Trying now...
Below is a screen grab of the slide out when importing a an existing table.
I'm confused why there is an option to select chain id and table id. If you're importing a table doesn't that mean that you would be using an existing tableland table in a project?
I found what might be an existing bug: If I import tables into a project, then I go to the project page via the normal navigation links, I don't see any of the tables. When I do a hard refresh on the page the imported tables are in the project.
I found what might be an existing bug: If I import tables into a project, then I go to the project page via the normal navigation links, I don't see any of the tables. When I do a hard refresh on the page the imported tables are in the project.
I can confirm this issue does not exist on production, but the same thing happens when I import a schema.
Will try to reproduce those bugs @joewagner, thanks.
Below is a screen grab of the slide out when importing a an existing table.
I'm confused why there is an option to select chain id and table id. If you're importing a table doesn't that mean that you would be using an existing tableland table in a project?
Yea, we preset those fields to the correct values, we could go an additional step and make them non editable?
I found what might be an existing bug: If I import tables into a project, then I go to the project page via the normal navigation links, I don't see any of the tables. When I do a hard refresh on the page the imported tables are in the project.
Fixed. Good catch.
I found what might be an existing bug: If I import tables into a project, then I go to the project page via the normal navigation links, I don't see any of the tables. When I do a hard refresh on the page the imported tables are in the project.
I can confirm this issue does not exist on production, but the same thing happens when I import a schema.
Also fixed.
Below is a screen grab of the slide out when importing a an existing table. I'm confused why there is an option to select chain id and table id. If you're importing a table doesn't that mean that you would be using an existing tableland table in a project?
Yea, we preset those fields to the correct values, we could go an additional step and make them non editable?
Went ahead and disabled those form inputs if chain and table id presets are provided.
Note: @joewagner this branch was just rebased and then force-pushed to origin.
Ok, I think all feedback so far has been addressed. Looking good with the new theme too.
The new feature here is a popover menu on the tableland table page/deployment page that allows the user to import the table into an existing project or use the table schema in a new table within a project.
This led to upgrades to trpc and iron-session, which caused lots of files to be touched.
I commented on every file with changes worth knowing about and reviewing. If a file has no comments, it's because the changes were already discussed in a previous file (usually just some naming change or api usage refactor), so you can breeze past those.