tablelandnetwork / tableland-js

Mono-repo containing Tableland JS libraries and tools
13 stars 1 forks source link

Update to ethers v6 #137

Closed dtbuchholz closed 5 months ago

dtbuchholz commented 5 months ago

Summary

Closes #77.

Details

Note: node 16 has been dropped in hardhat & @tableland/evm, so expect that test to fail.

How it was tested

Updated all tests across all clients.

Checklist:

dtbuchholz commented 5 months ago

@joewagner this is a hefty one! it includes both the ethers v6 and amoy changes.

it took forever to figure out that flakey nonce issue, but things finally work. note that we're dropping node 16 support, so that test doesn't matter.

I'm in the process of updating the studio with these changes. ideally, we:

  1. publish the sdk, node-helpers, and local
  2. publish the studio-cli
  3. bump the studio-cli in this repo's cli package.
  4. publish the cli package
joewagner commented 5 months ago

@joewagner this is a hefty one! it includes both the ethers v6 and amoy changes.

it took forever to figure out that flakey nonce issue, but things finally work. note that we're dropping node 16 support, so that test doesn't matter.

Nice work! This has been a long time coming. Dropping node 16 makes sense to me, looks like you removed it from the test workflow matrix. Can we also remove it from the review workflow matrix and add version 20. https://github.com/tablelandnetwork/tableland-js/blob/main/.github/workflows/review.yml#L18

I'm in the process of updating the studio with these changes. ideally, we:

  1. publish the sdk, node-helpers, and local
  2. publish the studio-cli
  3. bump the studio-cli in this repo's cli package.
  4. publish the cli package

I'll start working through reviewing all of this, and let's plan on releasing early next week.

joewagner commented 5 months ago

@dtbuchholz Looks like you need to run prettier. Potentially related to #136

dtbuchholz commented 5 months ago

(@joewagner rebased this on the latest changes from main, looks like that fixed the review workflow issue!)

joewagner commented 5 months ago

@dtbuchholz I just pushed a commit with some updated versions of the studio. I think we are gtg for Monday.

The only notable thing is that since we have two monorepos with a circular dependency, I had to do something a little hacky to enable us to publish everything simultaneously next week. I had to temporarily move the sdk and local out of the monorepo and publish a next version of those so that the studio could properly npm install and npm run build. After that I published the next versions of studio without issue, which then allow us to npm install and npm run build this monorepo normally. The only resulting weirdness is that I had to add two lint ignores and ts ignores to the local up.ts file. This is because in the monorepo there's no error, but when the directory gets moved out of the npm workspace there is an error.

tl;dr; we can either just leave them incase we do something like this again, or remove them once all the latest releases are published.

dtbuchholz commented 5 months ago

gotcha. i suppose if leaving those files doesn't impact anything negatively, then why not do so...just in case we have a major bump in the future, which I'm guessing will happen