search

tablelandnetwork / tableland-js

Mono-repo containing Tableland JS libraries and tools
13 stars 1 forks source link

(local) add more extraneous log filters #143

Closed joewagner closed 5 months ago

joewagner commented 5 months ago

With recent upgrades the messages hardhat logs have changed a little bit. This PR filters out a few new log messages that come in at a regular basis regardless of if there is anything happening on the network. This also alphabetizes the log message filters.

dtbuchholz commented 5 months ago

optionally, we could also remove a log that's erroneously included for anvil_metadata...it'll log something like this:

[Registry] eth_gasPrice
[Registry] eth_chainId
[Registry] anvil_metadata - Method not supported
[Registry] hardhat_metadata
[Registry] eth_chainId
[Registry] anvil_metadata - Method not supported
[Registry] hardhat_metadata
[Registry] eth_blockNumber
[Registry] eth_sendTransaction

i think it's coming from hardhat

joewagner commented 5 months ago

optionally, we could also remove a log that's erroneously included for anvil_metadata...it'll log something like this:

[Registry] eth_gasPrice
[Registry] eth_chainId
[Registry] anvil_metadata - Method not supported
[Registry] hardhat_metadata
[Registry] eth_chainId
[Registry] anvil_metadata - Method not supported
[Registry] hardhat_metadata
[Registry] eth_blockNumber
[Registry] eth_sendTransaction

i think it's coming from hardhat

I haven't noticed that one, but if you're seeing it we can add that too.

joewagner commented 5 months ago

tbc, the concept of the filters is to avoid having the network logs changing if you (the developer) aren't interacting with the network.
The message "anvil_metadata - Method not supported" makes it sound like some client is trying to interact with the network and failing. If that's the case, we do want to log that since the dev is going to want to know about it. When are you seeing those messages?

dtbuchholz commented 5 months ago

When are you seeing those messages?

It looks like it only happens on startup...I thought it was after every tx, so it's less of a big deal than I thought:

> npx local-tableland
[Registry] Started HTTP and WebSocket JSON-RPC server at http://127.0.0.1:8545/
[Registry]
[Registry]
[Registry] Accounts
[Registry] ========
[Registry]
[Registry] WARNING: These accounts, and their private keys, are publicly known.
[Registry] Any funds sent to them on Mainnet or any other live network WILL BE LOST.
[Registry]
[Registry] Account #0: 0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266 (10000 ETH)
[Registry] Private Key: 0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80
[Registry]
[Registry] Account #1: 0x70997970C51812dc3A010C7d01b50e0d17dc79C8 (10000 ETH)
[Registry] Private Key: 0x59c6995e998f97a5a0044966f0945389dc9e86dae88c7a8412f4603b6b78690d
[Registry]
[Registry] Account #2: 0x3C44CdDdB6a900fa2b585dd299e03d12FA4293BC (10000 ETH)
[Registry] Private Key: 0x5de4111afa1a4b94908f83103eb1f1706367c2e68ca870fc3fb9a804cdab365a
[Registry]
[Registry] Account #3: 0x90F79bf6EB2c4f870365E785982E1f101E93b906 (10000 ETH)
[Registry] Private Key: 0x7c852118294e51e653712a81e05800f419141751be58f605c371e15141b007a6
[Registry]
[Registry] Account #4: 0x15d34AAf54267DB7D7c367839AAf71A00a2C6A65 (10000 ETH)
[Registry] Private Key: 0x47e179ec197488593b187f80a00eb0da91f1b9d0b13f8733639f19c30a34926a
[Registry]
[Registry] Account #5: 0x9965507D1a55bcC2695C58ba16FB37d819B0A4dc (10000 ETH)
[Registry] Private Key: 0x8b3a350cf5c34c9194ca85829a2df0ec3153be0318b5e2d3348e872092edffba
[Registry]
[Registry] Account #6: 0x976EA74026E726554dB657fA54763abd0C3a0aa9 (10000 ETH)
[Registry] Private Key: 0x92db14e403b83dfe3df233f83dfa3a0d7096f21ca9b0d6d6b8d88b2b4ec1564e
[Registry]
[Registry] Account #7: 0x14dC79964da2C08b23698B3D3cc7Ca32193d9955 (10000 ETH)
[Registry] Private Key: 0x4bbbf85ce3377467afe5d46f804f221813b2bb87f24d81f60f1fcdbf7cbf4356
[Registry]
[Registry] Account #8: 0x23618e81E3f5cdF7f54C3d65f7FBc0aBf5B21E8f (10000 ETH)
[Registry] Private Key: 0xdbda1821b80551c9d65939329250298aa3472ba22feea921c0cf5d620ea67b97
[Registry]
[Registry] Account #9: 0xa0Ee7A142d267C1f36714E4a8F75612F20a79720 (10000 ETH)
[Registry] Private Key: 0x2a871d0798f97d79848a013d4936a73bf4cc922c825d33c1cf7073dff6d409c6
[Registry]
[Registry] Account #10: 0xBcd4042DE499D14e55001CcbB24a551F3b954096 (10000 ETH)
[Registry] Private Key: 0xf214f2b2cd398c806f84e317254e0f0b801d0643303237d97a22a48e01628897
[Registry]
[Registry] Account #11: 0x71bE63f3384f5fb98995898A86B02Fb2426c5788 (10000 ETH)
[Registry] Private Key: 0x701b615bbdfb9de65240bc28bd21bbc0d996645a3dd57e7b12bc2bdf6f192c82
[Registry]
[Registry] Account #12: 0xFABB0ac9d68B0B445fB7357272Ff202C5651694a (10000 ETH)
[Registry] Private Key: 0xa267530f49f8280200edf313ee7af6b827f2a8bce2897751d06a843f644967b1
[Registry]
[Registry] Account #13: 0x1CBd3b2770909D4e10f157cABC84C7264073C9Ec (10000 ETH)
[Registry] Private Key: 0x47c99abed3324a2707c28affff1267e45918ec8c3f20b8aa892e8b065d2942dd
[Registry]
[Registry] Account #14: 0xdF3e18d64BC6A983f673Ab319CCaE4f1a57C7097 (10000 ETH)
[Registry] Private Key: 0xc526ee95bf44d8fc405a158bb884d9d1238d99f0612e9f33d006bb0789009aaa
[Registry]
[Registry] Account #15: 0xcd3B766CCDd6AE721141F452C550Ca635964ce71 (10000 ETH)
[Registry] Private Key: 0x8166f546bab6da521a8369cab06c5d2b9e46670292d85c875ee9ec20e84ffb61
[Registry]
[Registry] Account #16: 0x2546BcD3c84621e976D8185a91A922aE77ECEc30 (10000 ETH)
[Registry] Private Key: 0xea6c44ac03bff858b476bba40716402b03e41b8e97e276d1baec7c37d42484a0
[Registry]
[Registry] Account #17: 0xbDA5747bFD65F08deb54cb465eB87D40e51B197E (10000 ETH)
[Registry] Private Key: 0x689af8efa8c651a91ad287602527f3af2fe9f6501a7ac4b061667b5a93e037fd
[Registry]
[Registry] Account #18: 0xdD2FD4581271e230360230F9337D5c0430Bf44C0 (10000 ETH)
[Registry] Private Key: 0xde9be858da4a475276426320d5e9262ecfc3ba460bfac56360bfa6c4c28b4ee0
[Registry]
[Registry] Account #19: 0x8626f6940E2eb28930eFb4CeF49B2d1F2C9C1199 (10000 ETH)
[Registry] Private Key: 0xdf57089febbacf7ba0bc227dafbffa9fc08a93fdc68e1e42411a14efcf23656e
[Registry]
[Registry] WARNING: These accounts, and their private keys, are publicly known.
[Registry]
[Registry] Any funds sent to them on Mainnet or any other live network WILL BE LOST.
[Registry]
[Registry] eth_accounts
[Registry] hardhat_metadata
[Registry] hardhat_metadata (2)
[Registry] hardhat_metadata (3)
[Registry] hardhat_metadata (4)
[Registry] hardhat_metadata (5)
[Registry] hardhat_metadata (6)
[Registry] hardhat_metadata (7)
[Registry] hardhat_metadata (8)
[Registry] hardhat_metadata (9)
[Registry] hardhat_metadata (10)
[Registry] hardhat_metadata (11)
[Registry] hardhat_metadata (12)
[Registry] hardhat_metadata (13)
[Registry] hardhat_metadata (14)
[Registry] hardhat_metadata (15)
[Registry] hardhat_metadata (16)
[Registry] hardhat_metadata (17)
[Registry] hardhat_metadata (18)
[Registry] hardhat_metadata (19)
[Registry] hardhat_metadata (20)
[Registry] eth_accounts
[Registry] hardhat_metadata
[Registry] hardhat_metadata (2)
[Registry] hardhat_metadata (3)
[Registry] hardhat_metadata (4)
[Registry] hardhat_metadata (5)
[Registry] hardhat_metadata (6)
[Registry] hardhat_metadata (7)
[Registry] hardhat_metadata (8)
[Registry] hardhat_metadata (9)
[Registry] hardhat_metadata (10)
[Registry] hardhat_metadata (11)
[Registry] hardhat_metadata (12)
[Registry] hardhat_metadata (13)
[Registry] hardhat_metadata (14)
[Registry] hardhat_metadata (15)
[Registry] hardhat_metadata (16)
[Registry] hardhat_metadata (17)
[Registry] hardhat_metadata (18)
[Registry] hardhat_metadata (19)
[Registry] hardhat_metadata (20)
[Registry] eth_gasPrice
[Registry] eth_chainId
[Registry] anvil_metadata - Method not supported
[Registry] hardhat_metadata
[Registry] eth_chainId
[Registry] anvil_metadata - Method not supported
[Registry] hardhat_metadata
[Registry] eth_blockNumber
[Registry] eth_sendTransaction
[Registry] Contract deployment: TablelandTables
[Registry] Contract address:    0x5fbdb2315678afecb367f032d93f642f64180aa3
[Registry] Transaction:         0x9b5e21410d0838f37b7fefaaf9ee5a4aa6b9ec58fe2137ccd11047a9be109a49
[Registry] From:                0xf39fd6e51aad88f6f4ce6ab8827279cfffb92266
[Registry] Value:               0 ETH
[Registry] Gas used:            4379695 of 30000000
[Registry] Block #5:            0xab13f67dccd12884fce58224418014d0930fc4659753e1c9964dc65d48736409
joewagner commented 5 months ago

Ah, startup meassages seem ok to me. I designed the filter to avoid having a huge log output if I step away from developing for a few hours.