search

tabler / tabler-icons

A set of over 5500 free MIT-licensed high-quality SVG icons for you to use in your web projects.
https://tabler.io/icons
MIT License
18.03k stars 898 forks source link

fix: Preact adapter spreading props as children #1084

Closed marvinhagemeister closed 4 months ago

marvinhagemeister commented 5 months ago

The Preact adapter has a bug where it spreads the remaining props as if they were children. But because random objects are not allowed to be rendered to prevent security vulnerabilities, Preact will throw an error. This works the same way in React.

Screenshot 2024-04-09 at 12 05 22

This issue can be fixed by spreading the remaining rest props into props where they belong. Basically, the same way as it's done in the React adapter.

Fixes https://github.com/denoland/fresh/issues/2400

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
tabler-icons ✅ Ready (Inspect) Visit Preview Apr 9, 2024 10:08am
github-actions[bot] commented 4 months ago

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

marvinhagemeister commented 4 months ago

bump

codecalm commented 4 months ago

thank you for help! 🙂