tabler / tabler-icons

A set of over 5700 free MIT-licensed high-quality SVG icons for you to use in your web projects.
https://tabler.io/icons
MIT License
18.31k stars 917 forks source link

`@tabler/icons-solidjs` 3.x.x bundle size issue #1215

Closed benoitv-code closed 1 month ago

benoitv-code commented 2 months ago

Description

I have a Vite project importing symbols from @tabler/icons-solidjs.

When using @tabler/icons-solidjs version 2.47.0, the bundle size is 115.59 kB When using @tabler/icons-solidjs version 3.14.0, the bundle size is 2,795.96 kB

This is a huge bump. My package.json defines "type": "module", so I think the correct esm module should be imported, keeping only the imported symbols.

Is there an issue with @tabler/icons-solidjs version 3 in that regard?

I've seen #793 and #1161, but I am not sure they are related.

Package

Version

3.14.0

Browser

Operating system

Steps to reproduce

  1. Create a vite project
  2. Import import { IconSearch } from "@tabler/icons-solidjs";
  3. Build the client code
  4. Notice the huge bundle size

Checklist

goenning commented 1 month ago

@inetol doesn't seem like that PR made much difference, still seeing this issue on 3.18.0, did it work for you?

inetol commented 1 month ago

The PR didn't make it to 3.18.0, if it's not reverted for some reason it should be included in the next release

goenning commented 1 month ago

oh, that explains, thanks :)