Fix ESM resolution in `@tabler/icons-react`

tabler / tabler-icons

A set of over 5700 free MIT-licensed high-quality SVG icons for you to use in your web projects.

https://tabler.io/icons

MIT License

18.33k stars 919 forks source link

Fix ESM resolution in `@tabler/icons-react` #1231

Closed MonsterDeveloper closed 1 week ago

MonsterDeveloper commented 1 month ago

Issue

Currently the ESM environment still resolves to CJS exports, according to AreTheTypesWrong: CleanShot 2024-09-27 at 22 04 21@2x

Changes made

I've fixed the file extensions settings in rollup.config: .js/.tsfor CJS and .mjs/.mts for ESM (since there's no type: module in package.json).

I've also included exports in the package.json to explicitly specify files to resolve to.

Now all the environments resolve correctly: CleanShot 2024-09-27 at 22 02 32@2x

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
tabler-icons	✅ Ready (Inspect)	Visit Preview	Sep 27, 2024 8:07pm

github-actions[bot] commented 3 weeks ago

This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 1 week ago

This pr was closed because it has been inactive for 14 days since being marked as stale.