tabler / tabler-icons

A set of over 5700 free MIT-licensed high-quality SVG icons for you to use in your web projects.
https://tabler.io/icons
MIT License
18.33k stars 919 forks source link

Error in `fix-outline.py` causes webfont icons build to fail #1258

Closed ethancrawford closed 1 week ago

ethancrawford commented 4 weeks ago

Description

After running the steps described below in Steps to reproduce, the console eventually spits out multiple errors during the build process every time it attempts to run /packages/icons-webfont/.build/fix-outline.py - Eg:

pnpm build:webfont

> tabler-icons@3.20.0 build:webfont /home/ethan/repos/tabler-icons
> pnpm --filter @tabler/icons-webfont build

> @tabler/icons-webfont@3.20.0 build /home/ethan/repos/tabler-icons/packages/icons-webfont
> pnpm run copy && pnpm run build:prepare && pnpm run build:outline && pnpm run build:webfont && pnpm run build:css

> @tabler/icons-webfont@3.20.0 copy /home/ethan/repos/tabler-icons/packages/icons-webfont
> pnpm run copy:license

> @tabler/icons-webfont@3.20.0 copy:license /home/ethan/repos/tabler-icons/packages/icons-webfont
> cp ../../LICENSE ./LICENSE

> @tabler/icons-webfont@3.20.0 build:prepare /home/ethan/repos/tabler-icons/packages/icons-webfont
> mkdir -p icons-outlined dist && rm -fdr dist/*

> @tabler/icons-webfont@3.20.0 build:outline /home/ethan/repos/tabler-icons/packages/icons-webfont
> node .build/build-outline.mjs

outline a-b-2
Stroke for: a-b-2 f25f
Copyright (c) 2000-2024. See AUTHORS for Contributors.
 License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
 with many parts BSD <http://fontforge.org/license.html>. Please read LICENSE.
 Version: 20201107
 Based on sources from 2024-06-24 13:55 UTC-ML-D-GDK3.
PythonUI_Init()
copyUIMethodsToBaseTable()
Traceback (most recent call last):
  File "/home/ethan/repos/tabler-icons/packages/icons-webfont/.build/fix-outline.py", line 4, in <module>
    file = sys.argv[1]
NameError: name 'sys' is not defined
Error: Command failed: fontforge -lang=py -script .build/fix-outline.py icons-outlined/outline/uF25F-a-b-2.svg

Package

Version

3.20.0

Browser

Operating system

Steps to reproduce

Checklist

Greatness7 commented 1 week ago

See #1069 from 7 months ago.

ethancrawford commented 1 week ago

Ha. Oh well, I thought I'd done a reasonable search through the past issues 😂🤷