search

tablespoon / fun

232 stars 52 forks source link

Support 24hour time and show 4 clocks #2

Closed chicks-net closed 11 years ago

chicks-net commented 11 years ago

What do you think of this? I forgot to make a branch for it so I'm going to leave this alone until you say what you want to do with it.

chicks-net commented 11 years ago

On my systems this also slows things down enough that it is not completing a cycle in under a second so the display looks a bit weird. I like having all of the relevant timezones up at once so this is not a bad trade-off for me.

chicks-net commented 11 years ago

Is there anything I should do to make this more merge-worthy?

tablespoon commented 11 years ago

Merged! Love it; I have some ideas to potentially improve performance that I'll try out

chicks-net commented 11 years ago

Thanks for merging it even though it isn't purely an improvement. :)

I'll see what I can do for improving performance when i get a chance too. I'm not sure how to make it more efficient without rewriting it in something other than shell, but I'll keep mulling it.

I have made changes in another branch to add more timezones for a total of 7 and skip the seconds for all but the local timezone. I wouldn't worry about merging it until we deal with the performance issue. If you see something there worthwhile let me know.