search

tablespoon / fun

232 stars 52 forks source link

don't print error message on install #6

Closed yunake closed 9 years ago

yunake commented 9 years ago

when running this script for the first time, the addnhosts list is empty resulting in the following message:

uci: Entry not found

this is not very user-friendly for the uninitiated :)

tablespoon commented 9 years ago

Are you running Chaos Calmer? I've had a few people mention that message, all running CC. I've only tested with Barrier Breaker. Thanks for explaining what's happening in CC!

tablespoon commented 9 years ago

Updated my reddit post giving you credit. Also added a new pastebin link and checksum.

yunake commented 9 years ago

wow, thanks :) this is such a minor thing really

yes this was observed on CC. i don't have anything else handy to test though.

ryanknapper commented 9 years ago

I saw this on Attitude Adjustment as well.

tablespoon commented 9 years ago

yunake: No problem! Contributors should be credited for their efforts. Thanks for improving it!

ryanknapper: Based on your comment, I went back and tested by running 'uci del dhcp.@dnsmasq[0].addnhosts' followed by ./adblocker.sh (with yunake's patch removed). Sure enough, it spat out that message. I must have seen it one time very early in development and completely forgotten about it.

Thanks to both of you.