search

tablexi / tablexi-logger

[DEPRECATED] A standardized logging interface for Table XI applications
MIT License
1 stars 0 forks source link

Downdate syntax to work with Ruby 1.9 #5

Closed drench closed 9 years ago

drench commented 9 years ago

This is all green for me under Rubies 1.9.3, 2.0.0, 2.1.7 and 2.2.3.

Converting from %i() wasn't too bad but I had to take a shower after turning the keyword arguments into an options hash.

I wouldn't mind keeping this as a separate branch for the few projects that need it, with the understanding that its days are numbered.

soulcutter commented 9 years ago

I actually don't mind at all having this compatibility patch in the master tree. It would be nice to at least have ONE version of this lib that older projects could use, even if we break compatibility in the future.

Isn't there a way to build on multiple rubies in CircleCI? Should probably do that.

jhanggi commented 9 years ago

As long as we still have active projects running 1.9.3, I think it's a good idea to support it within master. And running against multiple ruby versions in CI would be good for when one of future us forgets that we need to support older versions and commits a keyword argument.

drench commented 9 years ago

Options hash updated