search

taborlab / Iris

The Light Program Interface
BSD 3-Clause "New" or "Revised" License
12 stars 2 forks source link

Make 'enter custom timepoints' functional #164

Closed SynbioLucas closed 9 years ago

BrianLandry commented 9 years ago

How should this function? Another spreadsheet or uploading a file? I should be able uploading a CSV easily now

BrianLandry commented 9 years ago

Also, is this a publication or fancy level feature, I forgot how much motivation there was to implement this.

SynbioLucas commented 9 years ago

This should be a high priority feature since the only other way to implement this would be using an Arb waveform. I would be ok with just having a comma separated list of times in ms, similar to how we do intensities for step & const. If y'all wanna do something more fancy, that's fine too, but I think this would be sufficient.

We also need to animate/create the change from linearly spaced inputs to user-specified inputs; right now, the button does nothing.

On Mon, May 11, 2015 at 12:02 PM Brian notifications@github.com wrote:

Also, is this a publication or fancy level feature, I forgot how much motivation there was to implement this.

— Reply to this email directly or view it on GitHub https://github.com/rice-bioe/LPI/issues/164#issuecomment-100979122.

BrianLandry commented 9 years ago

Agreed its required for publication version. I think it should be implemented similarly to constant waveform intensities, so a text input formatted as a CSV. Its constrained by the well number. It also should share the number of Replicates with the algorithmic time point input

On Mon, May 11, 2015, 12:11 PM Lucas Hartsough notifications@github.com wrote:

This should be a high priority feature since the only other way to implement this would be using an Arb waveform. I would be ok with just having a comma separated list of times in ms, similar to how we do intensities for step & const. If y'all wanna do something more fancy, that's fine too, but I think this would be sufficient.

We also need to animate/create the change from linearly spaced inputs to user-specified inputs; right now, the button does nothing.

On Mon, May 11, 2015 at 12:02 PM Brian notifications@github.com wrote:

Also, is this a publication or fancy level feature, I forgot how much motivation there was to implement this.

— Reply to this email directly or view it on GitHub https://github.com/rice-bioe/LPI/issues/164#issuecomment-100979122.

— Reply to this email directly or view it on GitHub https://github.com/rice-bioe/LPI/issues/164#issuecomment-100981347.