taborlab / Iris

The Light Program Interface
BSD 3-Clause "New" or "Revised" License
12 stars 2 forks source link

Enable input of top/bottom LED wavelengths for LPA devices #224

Open SynbioLucas opened 9 years ago

SynbioLucas commented 9 years ago

This will be nice because:

  1. False coloring will work
  2. LED selectors can be populated with a wavelength instead of "Top" and "Bottom"
KarlGerhardt commented 9 years ago

I would call this a luxury. But by all means go for it. On Oct 9, 2015 6:36 PM, "Lucas Hartsough" notifications@github.com wrote:

This will be nice because:

  1. False coloring will work
  2. LED selectors can be populated with a wavelength instead of "Top" and "Bottom"

— Reply to this email directly or view it on GitHub https://github.com/rice-bioe/Iris/issues/224.

SynbioLucas commented 9 years ago

Yeah, absolutely. It's currently filed away under the "Fancy Version" milestone, so nobody's actively working on this until all the Publication Issues are closed.

-L

On Fri, Oct 9, 2015 at 6:55 PM KarlGerhardt notifications@github.com wrote:

I would call this a luxury. But by all means go for it. On Oct 9, 2015 6:36 PM, "Lucas Hartsough" notifications@github.com wrote:

This will be nice because:

  1. False coloring will work
  2. LED selectors can be populated with a wavelength instead of "Top" and "Bottom"

— Reply to this email directly or view it on GitHub https://github.com/rice-bioe/Iris/issues/224.

— Reply to this email directly or view it on GitHub https://github.com/rice-bioe/Iris/issues/224#issuecomment-147013423.

SynbioLucas commented 9 years ago

As of 3cb4912766ebb24a84ca7f1051f4c89bfefea3af, the false color toggle is only displayed on non-LPA devices. If this issue is fixed, make sure to remove these checks (see commit).

BrianLandry commented 8 years ago

@SynbioLucas I'm confused if this is still an issue or not? it seems this is just describing a standard 4x6 device with wavelengths instead of Top and Bottem

SynbioLucas commented 8 years ago

I agree, it's a luxury. At the moment, we're basically forcing people to use false coloring in the only device remaining in Iris, the LPA. If users were able to enter wavelengths for 'Top' and 'Bottom', the output would be more relevant to users using exotic wavelengths, and selecting between false colors or not would be meaningful.