search

taborlab / Iris

The Light Program Interface
BSD 3-Clause "New" or "Revised" License
12 stars 2 forks source link

PWM Waveform Inputs #247

Open KarlGerhardt opened 8 years ago

KarlGerhardt commented 8 years ago

How hard would it be to add a PWM option?

BrianLandry commented 8 years ago

My guess is that it would be fairly time consuming

On Sun, Nov 8, 2015, 4:00 PM KarlGerhardt notifications@github.com wrote:

How hard would it be to add a PWM option?

— Reply to this email directly or view it on GitHub https://github.com/rice-bioe/Iris/issues/247.

SynbioLucas commented 8 years ago

To elaborate a bit, one point Brian and I considered including PWM in the list of available waveforms, but decided against it because it just didn't seem like it was worth the time & effort:

  1. As far as I know, nobody is actively using PWM in their plate experiments, nor will any PWM experiments be included in the paper
  2. PWM experiments can be easily created using the Python LPF generation code, which is how I created mine when I was doing those experiments
  3. There is no clear use for PWM inputs (though, I admit that this isn't the best reason not to make them)
  4. Making PWM inputs available would require:
    1. creating new UI elements (a few hours of Felix' time)
    2. adding the relevant Waveform code
    3. testing that correct PWM waveforms are produced
    4. Updating the relevant input validation code as well as the code related to saving/loading LPFs

I'd estimate this would take 10-15 man-hours. Overall, this is something we could do, but the benefits don't seem to be worth the time. If you want PWM inputs, we can talk about it though.