search

taborlab / Iris

The Light Program Interface
BSD 3-Clause "New" or "Revised" License
12 stars 2 forks source link

Time step setting #249

Closed BrianLandry closed 8 years ago

BrianLandry commented 8 years ago

@SynbioLucas Is this line and the two around it valid? https://github.com/rice-bioe/Iris/blob/master/js/form/formServices.js#L970

It appears we treat all waveforms the same, which seems fine.

SynbioLucas commented 8 years ago

These lines are leftover from my experiments with trying to decrease LPF file size by having a dynamically-determined time step, which in the end wasn't a huge performance enhancer (except for steady-state runs, obviously). Also, because we're not sending the LPFs over the web anymore, it doesn't really matter how big the LPFs are as long as they're created reasonably quickly, as they are now.

Anyway, these lines are leftovers from that and should have been deleted with the rest of that code. We can do this next time we make a commit; it's not really worth committing on its own.

On Tue, Nov 10, 2015 at 5:12 PM Brian notifications@github.com wrote:

@SynbioLucas https://github.com/SynbioLucas Is this line and the two around it valid? https://github.com/rice-bioe/Iris/blob/master/js/form/formServices.js#L970

It appears we treat all waveforms the same, which seems fine.

— Reply to this email directly or view it on GitHub https://github.com/rice-bioe/Iris/issues/249.