search

taborlab / Iris

The Light Program Interface
BSD 3-Clause "New" or "Revised" License
12 stars 2 forks source link

Clicking on Plate View simulation progress bar does nothing. #250

Closed KarlGerhardt closed 8 years ago

KarlGerhardt commented 8 years ago

Should I be able to jump around in time by clicking on the progress bar?

felixekn commented 8 years ago

This is an issue with plateview.

-Felix

On Nov 11, 2015, at 6:35 PM, KarlGerhardt notifications@github.com wrote:

Should I be able to jump around in time by clicking on the progress bar?

— Reply to this email directly or view it on GitHub https://github.com/rice-bioe/Iris/issues/250.

KarlGerhardt commented 8 years ago

Oops, right. Plate view.

SynbioLucas commented 8 years ago

It looks like nothing is listening to the slider and changes to it are being ignored. When the plate display gets updated at the next time step, the slider position just gets moved to the next time step instead of where the mouse put it.

SynbioLucas commented 8 years ago

As I said above, this happens because the slider's value has no impact on the timestep() function; rather, the slider's value is set by this function.

The best solution would be to simple have updateTime(percent) fire any time the slider is clicked (on-click="updateTime(percentTime)"), but unfortunately, this function is not in the $scope, and putting it there would require either some rewriting or some pointer gymnastics. Probably can be done, but not obvious. I may work on this later if other stuff is going well.

Edit: these functions are in simController.js btw.

felixekn commented 8 years ago

Any progress on this?

Sent from my iPhone

On Dec 28, 2015, at 7:35 PM, Lucas Hartsough notifications@github.com wrote:

As I said above, this happens because the slider's value has no impact on the timestep() function; rather, the slider's value is set by this function.

The best solution would be to simple have updateTime(percent) fire any time the slider is clicked (on-click="updateTime(percentTime)"), but unfortunately, this function is not in the $scope, and putting it there would require either some rewriting or some pointer gymnastics. Probably can be done, but not obvious. I may work on this later if other stuff is going well.

— Reply to this email directly or view it on GitHub.

BrianLandry commented 8 years ago

Fixed, also, clicking and dragging the time bar is really fun