taborlab / Iris

The Light Program Interface
BSD 3-Clause "New" or "Revised" License
12 stars 2 forks source link

"Wells in Use" does not reset back to null when all waveforms are closed within an experiment #276

Closed felixekn closed 8 years ago

BrianLandry commented 8 years ago

This is expected behavior for the following reasons:

  1. We treat an experiment as valid when it doesn't have any waveforms. Already we assume the lack of one waveform means 0 LED intensity for all LEDs of that wavelength, so it makes sense to propagate this assumption to the case where waveforms are missing for all wavelengths.
  2. It is possible to calculate the number of well taken up assuming each waveform reperesents a single waveform group, allowing for an adequate goes for the "Wells in Use" field without any waveforms.

For any changes with regards to this issue we would first was to decide if an experiment with no waveforms is condered valid. In fact if this change is made, the Wells in Use will already behave as expected, ie. not be calculated.

felixekn commented 8 years ago

Wasn't thinking correctly. "Wells in Use" is functioning correctly.