taborlab / Iris

The Light Program Interface
BSD 3-Clause "New" or "Revised" License
12 stars 2 forks source link

Think about file names #278

Closed BrianLandry closed 8 years ago

BrianLandry commented 8 years ago

I don't think this was ever done.

Primarily though I want to rename savefile.lpf to savefile.irs at a minimum. But am open to better suggestions. This should require anything but a name change in the saving code.

@SynbioLucas (I think you implemented this, could have been me) For the zip file, could the time be more understandable? I would suggest hhmmss. At the moment I think its giving a weird form like ms since 1970 or something.

SynbioLucas commented 8 years ago

The name can obviously be anything we want. I wanted to make sure the names were unique so that people wouldn't have to deal with overwrite dialogs every time they download an Iris zip. For the names to be guaranteed unique, there needs to be a date component, hence the current naming. HHMMSS could work but wouldn't be guaranteed unique. Maybe we dont' care about this. I personally couldn't care less what the name of the Zip folder is.

On Tue, Jan 5, 2016 at 6:38 PM Brian notifications@github.com wrote:

I don't think this was ever done.

Primarily though I want to rename savefile.lpf to savefile.irs at a minimum. This should require anything but a name change in the saving code.

@SynbioLucas https://github.com/SynbioLucas (I think you implemented this, could have been me) For the zip file, could the time be more understandable? I would suggest hhmmss. At the moment I think its giving a weird form like ms since 1970 or something.

— Reply to this email directly or view it on GitHub https://github.com/rice-bioe/Iris/issues/278.

BrianLandry commented 8 years ago

The edge case of downloading twice in one second can be handled fine by the operating system so I will implement both the changes I suggested.

BrianLandry commented 8 years ago

Fixed in 26b0a987b658ca22f9a5 and 14ff8d046012c5397335ee8a07a