taborlab / Iris

The Light Program Interface
BSD 3-Clause "New" or "Revised" License
12 stars 2 forks source link

Parsing function orientation is broken #77

Closed SynbioLucas closed 9 years ago

SynbioLucas commented 10 years ago

Currently, orientation is parsed using: this.orientation = func.find('input[class=RC]:checked').val(); which returns on, not row or anything else useful.

Is there a better way to parse this radio button status? For the time being, I'm basically saying if orientation isn't undefined, then it gets set to row, and if it is undefined, if gets set to col. Could probably be better.

BrianLandry commented 10 years ago

I think this is the correct technique to use, the code could be written more clearly:

this.orientation = row; //Default value if(func.find('input[class=CR]:checked').checked) { this.orientation = col; }

But its good enough for now

BrianLandry commented 9 years ago

Different orientations will no longer be supported