taborlab / Iris

The Light Program Interface
BSD 3-Clause "New" or "Revised" License
12 stars 2 forks source link

The last row of intensities in the LPF file should be 0 #83

Closed felixekn closed 10 years ago

felixekn commented 10 years ago

After a light program is ran, the last light intensities read are what the device maintains indefinitely. When a program ends, it should turn all LEDs off. To do this, the last row of the intensities in the LPF file should all be 0.

SynbioLucas commented 10 years ago

As of 949e42e90479b965e44ba107083c6e174e9ea610

When the LPF is written, the final time step sees all channel intensities changed to 0GS to turn off the device. This should work fine with all timesteps (that are whole divisors of the total time) because a final time step is always added to runs to accommodate this. But we should watch out for this potential problem anyway.

felixekn commented 10 years ago

This should actually be an option that the user toggles.

Sent from my iPhone

On Aug 6, 2014, at 7:44 PM, Lucas notifications@github.com wrote:

As of 949e42e

When the LPF is written, the final time step sees all channel intensities changed to 0GS to turn off the device. This should work fine with all timesteps (that are whole divisors of the total time) because a final time step is always added to runs to accommodate this. But we should watch out for this potential problem anyway.

— Reply to this email directly or view it on GitHub.