search

taborlab / Iris

The Light Program Interface
BSD 3-Clause "New" or "Revised" License
12 stars 2 forks source link

Time 0 in chart view is shifted right #86

Closed felixekn closed 9 years ago

felixekn commented 10 years ago

The x axis is shifted to the right, causing the y axis to intersect at x < 0 instead of at x = 0 as in previous versions of the LPI

felixekn commented 10 years ago

This bug pertains to master and not gh-pages.

SynbioLucas commented 10 years ago

This was done on purpose, to fix auto-x-tick selections that are created when step size becomes large relative to the length of the run. I would also like to fix/set the max x-value, but ran into some ugly overflow on the right padding that cuts off the last x-tick digit in runs whose total length is > 3 digits long.

felixekn commented 10 years ago

Okay. Makes sense.

On Aug 5, 2014, at 5:07 PM, Lucas notifications@github.com wrote:

This was done on purpose, to fix auto-x-tick selections that are created when step size becomes large relative to the length of the run. I would also like to fix/set the max x-value, but ran into some ugly overflow on the right padding that cuts off the last x-tick digit in runs whose total length is > 3 digits long.

— Reply to this email directly or view it on GitHub.

BrianLandry commented 10 years ago

Why is this marked as invalid? If its not longer an issue it should be closed

SynbioLucas commented 10 years ago

In the comment above, I mentioned that while the initial bug wasn't a bug, there is a related bug I want to fix which related to the right end of the x-axis. It could be made another issue, but it's still related. Whatevs. On Aug 8, 2014 1:53 PM, "Brian" notifications@github.com wrote:

Why is this marked as invalid? If its not longer an issue it should be closed

— Reply to this email directly or view it on GitHub https://github.com/rice-bioe/LPI/issues/86#issuecomment-51656047.