search

taborlab / LPA-hardware

CAD files and firmware of the LPA, and imager-based calibration script.
10 stars 6 forks source link

Remove stepSizeScaling from firmware code #31

Open castillohair opened 5 years ago

castillohair commented 5 years ago

Time step calibration is not necessary with the LPA board design v1.1. The firmware still has code to allow performing time step calibration, though. I think this should be erased.

castillohair commented 5 years ago

To expand on this, the only use case I can think of where deleting this section would be problematic is if a user downloads the most recent firmware and tries to program an LPA v1.0 board.

This begs the more general question, should the firmware, at any time, be compatible with every previous LPA PCB version? I think the answer is no, because this restriction could make the firmware really hard to update and maintain. Thus, what a user with an LPA v1.0 board should do is to download the LPA v1.0 firmware. And we should make that very clear and easy to do.

@KarlGerhardt if you have opinions on this let me know.