The new ndk directory is also no longer $ANDROID_HOME/ndk-bundle, but $ANDROID_HOME/ndk/<version>. I guess this is due to the new Sidy-by-side install method, where you can have multiple versions of the ndk installed.
-if ANDROID_NDK environment variables are not set and ANDROID_HOME is set,
then the conditional is expanded to check ndk-bundle first (backwards compatibility)
then if ndk-bundle dir does not exist, to check for ndk side-by-side dir, do a directory listing sorted alphanumeric and the highest version is selected as the path (it contains the source.properties file that is then parsed for version)
If that sounds like an acceptable sketch, this seems like an easy PR to do. What do you think?
The new
ndk
directory is also no longer$ANDROID_HOME/ndk-bundle
, but$ANDROID_HOME/ndk/<version>
. I guess this is due to the new Sidy-by-side install method, where you can have multiple versions of the ndk installed.Originally posted by @hidde-jan in https://github.com/tabrindle/envinfo/issues/168#issuecomment-622287198
Code reference: https://github.com/tabrindle/envinfo/blob/f1cd4da617082a5a278e6ea5e5d7ea09f6ee3a98/src/helpers/sdks.js#L52-L67
Suggest that
-if ANDROID_NDK environment variables are not set and ANDROID_HOME is set,
ndk
side-by-side dir, do a directory listing sorted alphanumeric and the highest version is selected as the path (it contains thesource.properties
file that is then parsed for version)If that sounds like an acceptable sketch, this seems like an easy PR to do. What do you think?