tabrindle / envinfo

Generate a report about your development environment for debugging and issue reporting
MIT License
753 stars 58 forks source link

Android NDK not detected in side-by-side installation style #218

Open mikehardy opened 2 years ago

mikehardy commented 2 years ago

The new ndk directory is also no longer $ANDROID_HOME/ndk-bundle, but $ANDROID_HOME/ndk/<version>. I guess this is due to the new Sidy-by-side install method, where you can have multiple versions of the ndk installed.

Originally posted by @hidde-jan in https://github.com/tabrindle/envinfo/issues/168#issuecomment-622287198


Code reference: https://github.com/tabrindle/envinfo/blob/f1cd4da617082a5a278e6ea5e5d7ea09f6ee3a98/src/helpers/sdks.js#L52-L67

Suggest that

-if ANDROID_NDK environment variables are not set and ANDROID_HOME is set,

If that sounds like an acceptable sketch, this seems like an easy PR to do. What do you think?

mikehardy commented 2 years ago

Hey @gengjiawen :wave: - I could make a PR based on the above sketch if it seems like a reasonable way to handle side-by-side android NDKs