search

tabrindle / envinfo

Generate a report about your development environment for debugging and issue reporting
MIT License
753 stars 58 forks source link

feat: support for finding firefox web browser on windows added #234

Closed SetTrend closed 1 year ago

SetTrend commented 1 year ago

I added support for finding the Firefox web browser on Windows.

However, I couldn't test or debug my changes as there were too many conventions I had to follow to get this running on my Windows machine.

Before merging, please test my changes. Thank you.

/fixes: #221

SetTrend commented 1 year ago

Tested my code now on my machine. Works like a charm.

thany commented 1 year ago

Instead of hard-coding C:\Program Files and C:\Program Files (x86), it's better to resolve %ProgramFiles% and %ProgramFiles(x86)%, respectively.

After all, the root drive doesn't neccesarily have to be C, and I believe some localised versions of Windows use a localised directory name as well.

SetTrend commented 1 year ago

Good thought! Changed that now.