Closed jazzido closed 7 years ago
Started work on branch fix/171
. Seems that the y coordinates of the extracted TextElement
s are off (fall outside of the Page boundaries)
Fixed for the reference document (acfc2ef5cdc6a9b509ff7d45cd4b14ffe5958113), all tests pass except for an RTL case (@jeremybmerrill can you take a look? my arabic is nil)
It's a good test failure. There was a problem in previous versions with a misplaced diacritic; with this new version on this branch, the diacritic is in the right place.
sweet. Should I just adjust the expectation in the test with the actual value?
I already did but forgot to push because I'm juggling a million things. When my computer is done updating, I'll push.
Jeremy B. Merrill Sent from my mobile device
On Jul 28, 2017 12:03 PM, "Manuel Aristarán" notifications@github.com wrote:
sweet. Should I just adjust the expectation in the test with the actual value?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tabulapdf/tabula-java/issues/171#issuecomment-318693383, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhdmjYSOEwueZHaEG-GUzcNcQySBrE6ks5sSgXmgaJpZM4OkdgI .
Nevermind, just did it here.
Ha, okeedoke. Works for me.
Jeremy B. Merrill Sent from my mobile device
On Jul 28, 2017 12:11 PM, "Manuel Aristarán" notifications@github.com wrote:
Nevermind, just did it here.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tabulapdf/tabula-java/issues/171#issuecomment-318696175, or mute the thread https://github.com/notifications/unsubscribe-auth/AAhdmnTXG4Mj7gqSQggEJjFgrVTjvo31ks5sSghIgaJpZM4OkdgI .
Reported by @jeremybmerrill in tabulapdf/tabula#707:
Test document: http://www1.nyc.gov/assets/nypd/downloads/pdf/crime_statistics/cs-en-us-pbms.pdf
0.9.2
Debug output
java -cp ~/Downloads/tabula-0.9.2-jar-with-dependencies.jar technology.tabula.debug.Debug -e cs-en-us-pbms.pdf
1.0.0
Debug output
java -cp ~/Downloads/tabula-1.0.0-jar-with-dependencies.jar technology.tabula.debug.Debug -e cs-en-us-pbms.pdf