tabulapdf / tabula-java

Extract tables from PDF files
MIT License
1.77k stars 412 forks source link

Enforce checkout with LF to fix Windows CI #518

Closed chezou closed 1 year ago

chezou commented 1 year ago

Windows CI fails when parsing CSV with line breaks within a cell. This is due to the difference of line endings between CRLF vs LF, and test CSV parser implementation.

To mitigate this issue, tweak Windows CI to enforce git checkout with LF.

chezou commented 1 year ago

I found that root cause is this line: https://github.com/tabulapdf/tabula-java/blob/3c2af18f7c3daedafb6a4d33ab5f818cdc468d09/src/test/java/technology/tabula/UtilsForTesting.java#L86

but, I gave up to fix this since I can't understand original intention for it.

chezou commented 1 year ago

@jazzido Can you approve for CI?

jazzido commented 1 year ago

thanks @chezou!