search

tabular-io / iceberg-kafka-connect

Apache License 2.0
192 stars 41 forks source link

Move to single catalog in integration tests #105

Closed bryanck closed 11 months ago

bryanck commented 11 months ago

After receiving some feedback, it was decided that the best path forward for the integration tests is to use a single catalog. The sink does not use any functionality specific to a particular catalog, so there is little need to test every catalog with the sink. Similarly, the integration tests should not need to tests every FileIO implementation.

This PR moves the integration tests back to using a representative catalog (REST catalog) and FileIO (S3FileIO) for the tests. These implementations were chosen mostly for convenience and ease of use.

cc @ajantha-bhat @danielcweeks

ajantha-bhat commented 11 months ago

After receiving some feedback, it was decided

No worries. We respect the decision. Previously we had a bug for JDBC catalog in this project(with catalog Name). Those things can be caught if we have integration tests with all the catalogs. I will still try to add all the catalog test case again once we contribute this to Iceberg repo.