search

tabulartools / pbi-explorer

This repo collects all the issue related to the PBI Explorer tool.
34 stars 0 forks source link

Report Comparer Diff Alerting #26

Open JeridInsight opened 1 year ago

JeridInsight commented 1 year ago

The feature request

In the Report Comparer, it delineates a "diff" by coloring the property red or green. But these are only visible when you are fully drilled down on that object's properties.

For instance, there are diffs associated with this visualization, but you can't tell unless you drill into it:

image

image

This might not be a big deal with smaller reports, as a Full Expand would reveal all the diffs and you'd be able to see them, but with a bigger report with lots of objects / properties, you would really have to drill through to find them.

I know that turning off the Show Identical Items will essentially filter out all the noise and only show you the diffs, but it would be nice to have a visual representation that alerts you to the fact that an object in the hierarchy has a diff "inside" of it.

Proposed solution

Add between the two Object / Property labels (in the area where the Refine Comparison drop-down lives) a Total Diffs count. And then on above each report's Object / Property pane a dedicated Total Adds, Total Deletes and Total Mods count. Then in the Object / Property tree, change the color of the text of the object that contains an Add, Delete, or Mod. Maybe different colors for the combinations, as an object could contain an Add and a Delete, or an Add and a Mod, etc.... Or just bold the ones that contain a diff to make it simple?

Additional context

No response

DBojsen commented 1 year ago

Hi @JeridInsight

We already have visual indicators that show that there is changes to a child object

271016565-0cff56ce-4c7a-4f81-8a23-799a6f81fd19

JeridInsight commented 1 year ago

Yep! You're right. I don't know how I missed those. Hahaha...

What do you think about the Total Diffs, Total Adds, Total Deletes, Total Mods?

DBojsen commented 1 year ago

I like the idea, and code wise it will be easy to implement - it's just a matter of not cluttering the UI to much. We'll keep your suggestion in mind.